search

bevry / envfile

Parse and write environment files with Node.js
Other
61 stars 10 forks source link

feat: handle comment line for parse and stringify #213

Open NamPNQ opened 1 year ago

NamPNQ commented 1 year ago

This PR will handle comment line

For simply I don't write a complicated parser to handle it, I just use symbol for handle line with comment

The benefits of use it is didn't break our object when pass to JSON.stringify

This PR also fix tests and add test case for handle comment line correctly

Close #192

balupton commented 10 months ago

@NamPNQ looks good, I'll rebase and merge sometime after my current batch of work

balupton commented 10 months ago

What are examples of symbol comments outside of parsed envfiles? I've never seem that stuff before and there isn't tests for stringifying such.

balupton commented 6 months ago

@gonzaloriestra can you review and resolve this?

gonzaloriestra commented 6 months ago

I'd love to help, but unfortunately I don't have time for it right now... I created the other PR because we needed that in Shopify... Sorry!

balupton commented 6 months ago

@gonzaloriestra no worries then, I'll probably get to it in April or May with my current backlog and availability. Would @shopify be interested in sponsoring to get their support in all my project's readmes https://github.com/sponsors/balupton — thanks again for your PR!

NamPNQ commented 6 months ago

What are examples of symbol comments outside of parsed envfiles? I've never seem that stuff before and there isn't tests for stringifying such.

@balupton Hey, I'm a bit confused. Could you rephrase that for me? Or just give me an example

balupton commented 6 months ago

@NamPNQ PR just needs tests and docs really