search

bevy / photo-editor

Photo editor with a lot of cool features
MIT License
881 stars 336 forks source link

don't support Swift4.0? #24

Open hengchengfei opened 6 years ago

hengchengfei commented 6 years ago
screen shot 2018-02-24 at 4 44 43 pm
majid701 commented 6 years ago

Looks like a great library. Would be nice to have swift 4.0 support.

annjawn commented 6 years ago

Just add @objc in front of all the #selector methods and the errors will go away.

AD-Paladins commented 6 years ago

I did it but it happens when i run it and use the pencil.

simulator screen shot - iphone 8 plus - 2018-05-09 at 12 22 52

The lines fade and start to going up.

annjawn commented 6 years ago

@titopalito did you try it on a device? I have seen this behavior in simulator, but it's a LOT LESS or non existent in a real device.

AD-Paladins commented 6 years ago

I'll try to get a real device then 😅. Thanks a lot 👍

ehsan-ff commented 6 years ago

I'm facing the same issue. It is less obvious on real device, but it still happens. Sometimes black diagonal lines appear after saving the image. Anyone knows how to fix this?

mhm-ibrahim commented 5 years ago

@hengchengfei Please update to the latest release 0.6 and update me :D