search

bevyengine / bevy-website

The source files for the official Bevy website
https://bevyengine.org
MIT License
193 stars 330 forks source link

Consistent link color for Bevy supporters section #1099

Open BD103 opened 6 months ago

BD103 commented 6 months ago

Edit: The links the the donation section on the home page use the browser-default color, instead of the Bevy themed one.

The link "The Quick Start Guide" is rgb(124, 144, 255), while the link "abledbody" is rgb(140, 140, 255). Should these be made the same color, since they are both links?

(Also weirdly enough the blue of "abledbody" shows up as a dark blue on my phone, likely due to an Apple shader. This is what helped me catch the different colors.)

image image
BD103 commented 6 months ago

Turns out "abledbody" is not styled with a color at all, so it uses the browser's default. I believe it is because the link is not within a .media-content class.

@TrialDragon, what are your thoughts on this? Should the donation section be wrapped in .media-content, or should the SCSS be edited? I think we should at least set the default for all <a> tags...

TrialDragon commented 6 months ago

Hmm, it feels like it'd maybe make more sense for the media content stuff to be the default, but maybe it was put under a class due to css specificity issues. For now, we should wrap the appropriate things that are missing the class with the .media_content class, but also look into moving those values out, and maybe into the html element css or somewhere just as universal by default.