search

bevyengine / bevy-website

The source files for the official Bevy website
https://bevyengine.org
MIT License
190 stars 323 forks source link

Changelog and contributors tools can fail to find PRs #1518

Open alice-i-cecile opened 3 days ago

alice-i-cecile commented 3 days ago

IMO: all of the missed PRs look like they got excluded because they were originally opened before the "from" date for the release

Discovered in #1516 / #1517.

ChristopherBiscardi commented 3 days ago

get_issues_and_prs gets all PRs since the origin date, which is going to be roughly 0.<last_major>.1's date. That set of PRs is what is is checked so any PR opened before that will not be included because the issues endpoint can not be sorted by "closed date". I believe the default sorting for the issues endpoint is "id, descending".

The older PRs may have to be fetched by id.