Deferred Rendering follow up items - Githubissues

bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust

https://bevyengine.org

Apache License 2.0

36k stars 3.55k forks source link

Deferred Rendering follow up items #10101

Open DGriffin91 opened 1 year ago

DGriffin91 commented 1 year ago

Due to the size of the Deferred Rendering PR it was decided to address some issues in follow PRs. This issue exists to track the progress of the issues identified in the PR code review

[ ] Make mesh pipeline code reusable https://github.com/bevyengine/bevy/pull/9258#discussion_r1301514675
[x] Use coordinate transformations from https://github.com/bevyengine/bevy/pull/9726 once it's merged
[ ] Don't unnecessarily recreate bindings/textures every frame https://github.com/bevyengine/bevy/pull/9258#discussion_r1342191472 https://github.com/bevyengine/bevy/pull/9258#discussion_r1342191971 https://github.com/bevyengine/bevy/pull/9258#discussion_r1349672439
[x] Automatically determine where/when the color attachment should be cleared: https://github.com/bevyengine/bevy/pull/9258#discussion_r1353824381
[x] Improve material UX to more cleanly support deferred+forward materials: https://github.com/bevyengine/bevy/pull/9258#pullrequestreview-1669400495 https://github.com/bevyengine/bevy/pull/9258#pullrequestreview-1672742236
[ ] Copy normals to prepass texture in subsequent pass to minimize deferred attachment size: https://github.com/bevyengine/bevy/pull/9258#discussion_r1357539129

JMS55 commented 8 months ago

@DGriffin91 Item #4 was done in https://github.com/bevyengine/bevy/pull/10325

BD103 commented 4 weeks ago

It looks like all the PRs listed above are now merged. Can I close this as completed?

DGriffin91 commented 4 weeks ago

@BD103 at the very least, still missing the last one. These reference comments in the initial PR. That's why they look merged.