FloatExt::lerp names value t instead of s

bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust

https://bevyengine.org

Apache License 2.0

35.84k stars 3.54k forks source link

Open Veritius opened 8 months ago

Veritius commented 8 months ago

https://docs.rs/bevy_math/0.13.0/bevy_math/trait.FloatExt.html#tymethod.lerp mentions a value t in the method signature that doesn't exist. It probably means s.

ekropotin commented 8 months ago

This trait is coming from Glam package. I've opened a PR for them

ekropotin commented 8 months ago

@OneFourth I'm sorry, I've just noticed you've been already working on it. I didn't mean to steal this task from you.

OneFourth commented 8 months ago

Ah no problem, I'll delete mine so the glam-rs maintainers can just merge in yours.

james7132 commented 7 months ago

This seems to be fixed upstream, just need a glam update.