DanteMarshal
commented
7 months ago Update
Made a few changes, after removing the for loop on mouse.read() I don't get the panics anymore.
I don't know if I'm doing something wrong or if this is really a bug !
Here's the new code, I still get the panics when I uncomment the mouse.read() loop.
use bevy::{
input::{keyboard::KeyboardInput, mouse::MouseMotion, ButtonState},
prelude::*,
};
fn main() {
App::new()
.add_plugins(DefaultPlugins)
.add_plugins(bevy_framepace::FramepacePlugin)
.add_systems(Startup, setup)
.add_systems(Update, update)
.run();
}
fn update(
mut cube: Query<(&mut Player, &mut Transform)>,
mut keys: EventReader<KeyboardInput>,
mut mouse: EventReader<MouseMotion>,
time: Res<Time>,
) {
let mut player = cube.single_mut();
for event in keys.read() {
if event.key_code == KeyCode::KeyR {
match event.state {
ButtonState::Pressed => player.0.move_direction.y = 1.0,
ButtonState::Released => player.0.move_direction.y = 0.0,
}
}
if event.key_code == KeyCode::KeyF {
match event.state {
ButtonState::Pressed => player.0.move_direction.y = -1.0,
ButtonState::Released => player.0.move_direction.y = 0.0,
}
}
if event.key_code == KeyCode::KeyW {
match event.state {
ButtonState::Pressed => player.0.move_direction.z = -1.0,
ButtonState::Released => player.0.move_direction.z = 0.0,
}
}
if event.key_code == KeyCode::KeyS {
match event.state {
ButtonState::Pressed => player.0.move_direction.z = 1.0,
ButtonState::Released => player.0.move_direction.z = 0.0,
}
}
if event.key_code == KeyCode::KeyD {
match event.state {
ButtonState::Pressed => player.0.move_direction.x = 1.0,
ButtonState::Released => player.0.move_direction.x = 0.0,
}
}
if event.key_code == KeyCode::KeyA {
match event.state {
ButtonState::Pressed => player.0.move_direction.x = -1.0,
ButtonState::Released => player.0.move_direction.x = 0.0,
}
}
}
let translation = time.delta_seconds()
* Vec3::new(
player.1.local_x().dot(player.0.move_direction),
player.1.local_y().dot(player.0.move_direction),
player.1.local_z().dot(player.0.move_direction),
);
player.1.translation += translation;
// for event in mouse.read() {
// player
// .1
// .rotate_local_axis(time.delta_seconds() * Vec3::X, event.delta.y);
// player
// .1
// .rotate_local_axis(time.delta_seconds() * Vec3::Y, event.delta.x);
// }
player.1.set_changed();
}
fn setup(
mut framepace: ResMut<bevy_framepace::FramepaceSettings>,
mut commands: Commands,
mut meshes: ResMut<Assets<Mesh>>,
mut materials: ResMut<Assets<StandardMaterial>>,
) {
framepace.limiter = bevy_framepace::Limiter::from_framerate(30.0);
// circular base
commands.spawn(PbrBundle {
mesh: meshes.add(Circle::new(4.0)),
material: materials.add(Color::WHITE),
transform: Transform::from_rotation(Quat::from_rotation_x(-std::f32::consts::FRAC_PI_2)),
..default()
});
// cube
commands.spawn(PbrBundle {
mesh: meshes.add(Cuboid::new(1.0, 1.0, 1.0)),
material: materials.add(Color::rgb_u8(124, 144, 255)),
transform: Transform::from_xyz(0.0, 0.5, 0.0),
..default()
});
// light
commands.spawn(PointLightBundle {
point_light: PointLight {
shadows_enabled: true,
..default()
},
transform: Transform::from_xyz(4.0, 8.0, 4.0),
..default()
});
// camera
commands.spawn((
Player::default(),
Camera3dBundle {
transform: Transform::from_xyz(-2.5, 4.5, 9.0).looking_at(Vec3::ZERO, Vec3::Y),
..default()
},
));
}
#[derive(Default, Component)]
struct Player {
move_direction: Vec3,
}
mweatherley
pablo-lua
ramirezmike
Bevy version
The release number or commit hash of the version you're using.
[Optional] Relevant system information
What you did
I'm trying to learn bevy, and I was making a very simple scene to move a cube. Here's the code :
What went wrong
Panics on one of the
local_?calls, Here's the backtrace from one of them :Additional information
I think it happens the moment I press a key that is the opposite of a key I pressed before. For example, if I press Left (KeyA) nothing happens, but then pressing Right (KeyS) will panic afterwards.