BorderlessFullscreen does not cover the menu bar on macOS

TarekAS commented 3 months ago

Bevy version

0.14.1

Relevant system information

cargo 1.80.1 (376290515 2024-07-16) macOS Sonoma 14.5

Automatically hide and show menu bar is set to Never in the system preferences.

What you did

Basic bevy app with BorderlessFullscreen enabled, running on macOS.

use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins.set(WindowPlugin {
            primary_window: Some(Window {
                mode: bevy::window::WindowMode::BorderlessFullscreen,
                resolution: bevy::window::WindowResolution::default(),
                ..default()
            }),
            ..default()
        }))
        .run();
}

What went wrong

Expectations: BorderlessFullscreen should cover the entire screen.

What actually happened: it didn't cover the menu bar

Additional information

Hovering near the menu bar also exposes the title bar

If this is not considered a bug, perhaps there should be an option to cover the entire menu bar as well.

alice-i-cecile commented 3 months ago

Can you reproduce this in winit itself? I suspect this is a bug upstream: once reproduced there please open an issue on their repo and link it here (or vice versa).

TarekAS commented 3 months ago

I investigated a bit and here's what I found:

I can confirm it's an issue with winit by simply trying one of their examples here and setting it to fullscreen using Ctrl+F, which triggers BorderlessFullscreen mode.
It used to be the case that BorderlessFullscreen hid the menu bar, but it was fixed in version v0.26.0.
The documentation around set_fullscreen is a bit weird. It says that Fullscreen::Borderless is the idiomatic way for fullscreen games to work on macOS, but it also says only Fullscreen::Exclusive disables the menu bar and the dock, which is a bit of a contradiction.
~There is an open issue (https://github.com/rust-windowing/winit/issues/2308) that seems related to this.~
A comment in the winit codebase seems to hint that it is not configurable for consistency purpose

It turns out I had set Automatically hide and show the menu bar to Never in my settings. However, in a bevy game, this should ignored and the menu bar should be hidden either way.

bevyengine / bevy