`bevy-glsl-to-spirv` is 38 MB of source code

bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust

https://bevyengine.org

Apache License 2.0

35.04k stars 3.44k forks source link

Closed jyn514 closed 2 years ago

jyn514 commented 3 years ago

f61e44db2824c0cc4b4815748c4d3f051002ada7

Ubuntu 20.04

git clone https://github.com/bevyengine/bevy && cargo check

Downloading bevy sources takes very little time.

Cargo takes over 38 MB to download the source code alone.

Downloaded 62 crates (48.4 MB) in 9.61s (largest was `bevy-glsl-to-spirv` at 37.9 MB)

jyn514 commented 3 years ago

I haven't looked into why it's so big, but 38 MB seems pretty giant.

GrygrFlzr commented 3 years ago

The problem is that it’s delivering literal binaries. It’s possible to always compile from source, but that brings a penalty to compilation times.

mockersf commented 3 years ago

You can find more information, and the path forward for that in #1073

TL;DR:

short term: provide easer support to shaderc (better compatibility and no binary to download, but more complicated setup)
long term: replace bevy-glsl-to-spirv by naga
hypothetical longer term? support rust-gpu

james7132 commented 2 years ago

Closing this as all shader transpilation is now done via naga, as of the 0.6 render rework.