bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust
https://bevyengine.org
Apache License 2.0
36.4k stars 3.59k forks source link

Properly set accessible value on label nodes #16418

Closed DataTriny closed 1 week ago

DataTriny commented 1 week ago

Objective

https://github.com/AccessKit/accesskit/pull/475 changed how text content should be set for AccessKit nodes with a role of Label. This was unfortunately missing from #16234.

Solution

When building an accesskit::Node with Role::Label, calls set_value instead of set_label on the node to set its content.

Testing

I can't test this right now on my Windows machine due to a compilation error with wgpu-hal I have no idea how to resolve.

github-actions[bot] commented 1 week ago

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨