superdump
commented
2 years ago I wonder if this should maybe use Rgba16Unorm.
The PNG image loader only knows that the components are 16-bit unsigned integer, it doesn't know how you want to use it. The PBR material shader binding is configured to always expect a floating point value, whether that is how it is stored, or how it is converted automatically when being sampled.
So, you should be able to load the texture, and when it is loaded, reconfigure it:
if let Some(image) = images.get_mut(image_handle) {
image.texture_descriptor.format = TextureFormat::Rgba16Unorm;
}If this is part of a model, you may have to delay spawning the model into the world until this change is made.
In future, these friction points would be addressed by a few things:
- image assets being used for normal map textures would automatically have their texture format reconfigured to a float mapping format, where necessary
- asset meta files would allow configuration of what texture format to use when the underlying data is in the same format, but the format can be converted to something else such as unsigned normalised float when sampling
@cart I think this is an interesting case to consider for asset stuff so just giving you a nudge to inject it into your brain. :)
Sheepyhead
bofh
alexniver
jancespivo
pcwalton
Bevy version
0.7.0
Operating system & version
Pop_OS! 21.10
What you did
I tried to use a normal texture which has a precision of "16-bit gamma integer".
What you expected to happen
I've expected to have the texture loaded normally and used with a
PbrBundle.What actually happened
Crash at runtime.
Additional information
I've compared my texture with other textures which work correctly :
Left is the image used by https://github.com/bevyengine/bevy/blob/main/examples/3d/texture.rs and right is the normal texture generating the wgpu validation error. The only difference I found was the precision.
After re-exporting the image to use 8-bit precision, the error is gone.