bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust
https://bevyengine.org
Apache License 2.0
36.41k stars 3.59k forks source link

Backtrack nightly versions when CI fails on nightly but not stable #5331

Open alice-i-cecile opened 2 years ago

alice-i-cecile commented 2 years ago

What problem does this solve or what need does it fill?

NIghtly regularly fails for reasons outside of control. Usually, this is because the latest version broke one of our dependencies.

Typically this is fixed pretty quickly (within a day or two) either in Rust or upstream. But until then, we can't merge PRs.

What solution would you like?

When the crate build on stable (but not nightly):

  1. Use the next most recent nightly version.
  2. If this fails again, repeat this several times.
  3. Log a relatively visible warning of this.

Additional context

For an example of the most recent breakage, see #5330, caused by the problem fixed in https://github.com/NotIntMan/inplace_it/pull/11

See this Zulip thread for a discussion with the Rustlang team about possible solutions on both ends.

mockersf commented 2 years ago

That could be quite hard to do with GitHub actions... and backtracking could be very costly (in time)

I would prefer:

That wouldn't add a lot of complexity to existing CI, but we would need a place to report the status