Add equivalent to kira's `Handle` or oddio's `Controlled` in `bevy_audio::Decodable` - Githubissues

bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust

https://bevyengine.org

Apache License 2.0

36.25k stars 3.58k forks source link

Add equivalent to kira's `Handle` or oddio's `Controlled` in `bevy_audio::Decodable` #5828

Open harudagondi opened 2 years ago

harudagondi commented 2 years ago

What problem does this solve or what need does it fill?

There should be a way to control a playing sound externally, outside of what is possible using AudioSink.
kira achieved this by returning a Handle in SoundData.
oddio achieved this by implementing Controlled for some Signal types.

What solution would you like?

In Decodable, add another associated type called Control (Handle is taken)
This Control is returned from Decodable::decoder(), alongside Decoder.
The Control is returned to the user when using Audio::play or other related functions.

What alternative(s) have you considered?

Just do not do this. lol
Embed Control in AudioSink.

Additional context

I am refactoring bevy_fundsp right now, and I want to resolve harudagondi/bevy_fundsp#2

SolarLiner commented 8 months ago

FWIW, rodio::Sink is already a kind of Handle, where control over the sound is done from the Sink and communicates to the audio thread to perform the requested changes. It's not a particularly good one, but I don't think there's much else to do from bevy_audio's side anyway, since with rodio it's the only way we have of controlling sounds.