bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust
https://bevyengine.org
Apache License 2.0
35.59k stars 3.52k forks source link

Bevy CI `check-bans` failing `found 2 duplicate entries for crate 'windows'` #7654

Closed LiamGallagher737 closed 1 year ago

LiamGallagher737 commented 1 year ago

Any PRs that edit the Cargo.toml will fail the check-bans check. Two examples of this are #7652 and #7648.

error[duplicate]: found 2 duplicate entries for crate 'windows'
    ┌─ /home/runner/work/bevy/bevy/Cargo.lock:322:1
    │  
322 │ ╭ windows 0.43.0 registry+https://github.com/rust-lang/crates.io-index
323 │ │ windows 0.44.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰────────────────────────────────────────────────────────────────────^ lock entries
    │ 

wgpu-hal updated 3 days ago, which bevy-render has a dependency on and now has a different version of windows

Here is the related discussion https://discord.com/channels/691052431525675048/1074588631622238289

LiamGallagher737 commented 1 year ago

These are the duplicates of the windows crate

windows v0.43.0
└── gilrs-core v0.5.2 (*)

windows v0.44.0
└── gpu-allocator v0.22.0 (*)

windows-sys v0.42.0
└── notify v5.1.0
    └── bevy_asset v0.9.0 (E:\Projects\bevy\crates\bevy_asset) (*)