Install zld when compiling for macOS if required

bevyengine / bevy_github_ci_template

Apache License 2.0

202 stars 45 forks source link

Install zld when compiling for macOS if required #22

Closed carrascomj closed 1 year ago

carrascomj commented 1 year ago

Description

When LLD is set as a linker, the macOS release step fails since it requires zld.

Implementation

Added a flag on the release action to set if LLD was configured (false by default). It installs zld from brew on the macos step.
Documented it at the README.

Although this gets the job done, the .cargo/ directory could be read to automatically determine if LLD is being use, withou the need of a flag, what do you think?

mockersf commented 1 year ago

after a quick check, we shouldn't recommend zld on macOS anymore: https://github.com/bevyengine/bevy/issues/7299

carrascomj commented 1 year ago

I didn't know that zld was in that state. I guess at some point ld64.lld will be available on LLVM, then. Closing this!