search

bevyengine / bevy_github_ci_template

Apache License 2.0
202 stars 45 forks source link

Remove GitHub token from Clippy workflow job #9

Closed TimJentzsch closed 2 years ago

TimJentzsch commented 2 years ago

This GitHub token reference seems unnecessary: https://github.com/bevyengine/bevy_github_ci_template/blob/3e0784af0159b3fe2eb0631d445fb00897c3183e/.github/workflows/ci.yaml#L73

mockersf commented 2 years ago

it is used to post clippy results using the GitHub api in PRs

TimJentzsch commented 2 years ago

What do you mean by that? They are left as a comment in the PR?

mockersf commented 2 years ago

yup, see the action: https://github.com/actions-rs/clippy-check