bewee / tuya-adapter

GNU General Public License v3.0
8 stars 8 forks source link

Feit Electric Devices #27

Open HyperCharlie opened 3 years ago

HyperCharlie commented 3 years ago

I just confirmed that the Feit Electric (sold at Costco!) indoor smart plugs work perfectly with this add on. Presumably their bulbs will also work, now that I have confirmed that some devices work I will get some more.

Thank you for this add on. I'm a developer but had never heard of Tuya, now I know way, way to much about it. I used the TinyTuya library for getting the keys to the devices, https://github.com/jasonacox/tinytuya, the walkthrough there of creating a Tuya developer account was by far the easiest method I found of getting the key. If I have some time I'll look at integrating the tinytuya wizard functionality into the add on, this may make it easier for non-developers eventually to use these devices. As it stands, they are a major PITA, I can't imagine a non-dev being able to use them!

bewee commented 3 years ago

Hi @HyperCharlie,

It's great to hear that the add-on is working for your device!😊 We are grateful for any contribution - So taking a look at integrating the wizard functionality would be pretty much appreciated :)

confirmed that the Feit Electric (sold at Costco!) indoor smart plugs work

Added to the list

the walkthrough there of creating a Tuya developer account was by far the easiest method I found of getting the key

Yeah, it's pretty painful. But I haven't heard of any more convenient method yet :/ It would definitely be great to improve the setup process because yes, currently it is kinda impossible for non-developers to setup these... If we may deliver the add-on together with an API key, it should be possible to integrate the setup process into the gateway's pairing process. I guess that would be a perfectly fine solution. Problem is, I don't know whether we are allowed to do this :\ Any thoughts? (Probably this should be outsourced into an own issue?)

Regards

kevin-garcia commented 3 years ago

Hi @bewee and @HyperCharlie,

I can confirm this works with FEIT Electric's Smart Wifi Bulb as well. A friend just sent me four of them (from Costco!), and I'd been looking for an excuse to try out the WebThings Gateway, so this seemed like the perfect time. I am so glad that after some minimal searching, I found this add on and decided to try it out. Thank you, @bewee for creating it!

As a non-developer, I was able to set it up! (It probably took me a bit longer than it should have, but I got it working eventually, and once I got the first bulb working, the others were easy.) I'm relatively computer-literate, though, so I do think most non-developers would throw their hands up at having to go through the developer account setup. Anything you can do to simplify the setup or cut that part out altogether would be a huge improvement in accessibility for normal folks.

Great job with the add on, though. I'm basking in the multi-colored light thanks to you!

All the best, Kevin

bewee commented 3 years ago

Hi @kevin-garcia,

Pretty glad to hear you got it working! Have added the bulb to the compatibility list. Did you need to use a custom config or did it work out-of-the-box?

Since setup is really a major issue, I opened a new one: #28

This issue here will stay open for communication related to other FEIT electric smart devices

Regards, Benedikt

kevin-garcia commented 3 years ago

@bewee it worked out of the box with no custom config. I initially thought I might need to customize, because the first light I tried paired fine, but didn't seem to be functioning properly (the bulb initially was able to change color, but then got stuck on one hue). I just "turned it off then on again" by re-pairing the bulb and that fixed it. All my other bulbs paired and worked with no issues.

Cheers, Kevin