Wip/rename carelink names

bewest / decoding-carelink

python serial driver for mm comlink2 protocol

http://bewest.github.io/decoding-carelink

Other

71 stars 52 forks source link

Wip/rename carelink names #153

Closed bewest closed 8 years ago

bewest commented 8 years ago

https://gist.github.com/ps2/bc4208080321c9a1b31b

bewest commented 8 years ago

probably not

[ ] "BolusWizardBolusEstimate" => "BolusWizard",
[ ] "BolusNormal" => "Bolus"

maybe

[ ] "JournalEntryPumpLowReservoir" => "LowReservoir",
[ ] "Suspend" => "PumpSuspend",
[ ] "Resume" => "PumpResume",

I think LowReservoir is a simpler name, but there's probably some value to making these match.

loudnate commented 8 years ago

FYI, Renaming suspend and resume will have a breaking effect on MMHistoryTools

On Dec 4, 2015, at 4:15 PM, Ben West notifications@github.com wrote:

probably not

"BolusWizardBolusEstimate" => "BolusWizard", "BolusNormal" => "Bolus" maybe

"JournalEntryPumpLowReservoir" => "LowReservoir", "Suspend" => "PumpSuspend", "Resume" => "PumpResume", I think LowReservoir is a simpler name, but there's probably some value to making these match.

— Reply to this email directly or view it on GitHub.

bewest commented 8 years ago

Please keep an eye out for this, @openaps/contributors