bewest / decoding-carelink

python serial driver for mm comlink2 protocol
http://bewest.github.io/decoding-carelink
Other
71 stars 52 forks source link

Wip/bolus wizard bg mmol units #157

Open sulkaharo opened 8 years ago

sulkaharo commented 8 years ago

Now running this in production and it works. I changed this to report the values in mgdl, as it's way easier to handle the data if decocare just decodes to one set of units consistently. So LGTM with my patch.

bewest commented 8 years ago

Not sure how I feel about this. Decocare is supposed to be stupid simple, like curl, it was originally a tool to tell exactly what is going on inside the device. In the past, I've been pretty disciplined/strict about separating conversions: https://github.com/openaps/openaps/blob/master/openaps/vendors/units.py, I think we're at a point where a better openaps medtronic should be created to make a lot of this easier: an oref0 version of the medtronic vendor.