search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.79k stars 299 forks source link

Radar dots cannot to be targeted sometimes #1488

Open 6AKU opened 1 year ago

6AKU commented 1 year ago

Conditions: Target unit is small and radar dot deviated from real unit position far.

https://youtu.be/ehy28yOQ8_k

SethDGamre commented 1 month ago

issue persists specifically, targetting via attack/set target commands cannot happen via clicking when the unit is outside radar range. Though, the dots show up. Those dots ARE targettable automatically by automatic means E.G weapon on fire at will no matter the range so long as the dot shows up and is within weapon range.

SethDGamre commented 3 weeks ago

Requesting review to determine the best way to fix this.

saurtron commented 2 weeks ago

Regarding this issue, not very sure about the description or what's going on. If the dots are outside of radar range how do they show up?

For cases of buildings that actually leave a radar trace outside of radar range I can see attack doesn't allow targeting, either through circle or direct click.

For radar dots when inside radar range seems to work fine, at least when I tested now I can click to attack them as well as area attack, but maybe I'm overlooking something.

This can be investigated, but I think it's something that can also affect balance, also a possible problem might be that you can have a radar trace but the building already be destroyed, so allowing targeting there can be problematic since it has to be done in a way not to leak information to players (likely this is why it's not implemented atm).

If everyone agrees they should be targeted then at some point the issue can be investigated, but currently it's not clear if it's actually wanted.

SethDGamre commented 2 weeks ago

Regarding this issue, not very sure about the description or what's going on. If the dots are outside of radar range how do they show up?

What's going on is the actual position of the unit is inside of radar range, but radar wobble causes them to drift in and out of radar range. When outside of radar range, they are not targetable.

At least that's what I remember from the issue

saurtron commented 2 weeks ago

Ok I understand now. I noticed also area command doesn't seem to choose based on the radar dot, but on the actual unit position, might be related.

saurtron commented 2 weeks ago

I think I know what's going on, it's not related to going out of radar range, but going out of Quad (internal buckets where units are placed to simplify collision detection).

GetQuadsOnRay doesn't return the quad where the units are and thus they aren't detected on mouseover or click.

On the other hand the circular selection fails because it doesn't take into account the radar wobble so just selects based on real position.