search

beyond-all-reason / Beyond-All-Reason

www.beyondallreason.info
Other
1.58k stars 259 forks source link

Move in Formation (Ctrl Left Click) conflict with Drag Move Formation (Right Click Drag) #2294

Open sprEEEzy opened 7 months ago

sprEEEzy commented 7 months ago

When doing Ctrl + Shift + Left Clicks (playing on 240 fps lock), it's very likely that you'll get at least 1 Right Click Drag move inserted, ruining your formation. See image below.

image

Solution: Disable right click drag while Ctrl is active.

sprEEEzy commented 7 months ago

Related: https://github.com/beyond-all-reason/Beyond-All-Reason/issues/2223 - different bug, most likely same root cause.

sprEEEzy commented 1 month ago

Another example of right click drag interfering with move in formation.

https://github.com/beyond-all-reason/Beyond-All-Reason/assets/9414375/b8af1b6d-6065-4c7c-914d-de9d21c76017

sprEEEzy commented 1 month ago

This is caused by CustomFormation2 Widget (possibly something more engine related as well).

Can be partially fixed by increasing this number. But, that comes with a downside of not being able to issue smaller formations. https://github.com/beyond-all-reason/Beyond-All-Reason/blob/53767e87ca9cae6df723df0e4d8c33d5b00312c8/luaui/Widgets/cmd_customformations2.lua#L38-L39

Proper fix would include disabling CustomFormation2 line functionality when CTRL is held to issue Move in Formation.