search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.8k stars 302 forks source link

FolsomDamR 1.16 claimable map resources gone #2673

Open h0lley opened 9 months ago

h0lley commented 9 months ago

Description

All trees, geo thermal plant spots, etc. are gone on FolsomDamR 1.16.

image

The map itself has not been updated.

Checking replays, I can say that 2024-02-16 22:56 <- claimables were still there 2024-02-19 12:39 <- claimables were gone

Is this

Expected Behaviour

FolsomDam having claimables as designed

Actual Behaviour

FolsomDam is suddenly missing claimables

Reproduction steps

  1. Start any kind of match on FolsomDamR 1.16
  2. Notice the empty spots in the center of the dam where claimables are supposed to be located, also notice that all trees are gone

Other

No response

sprunk commented 8 months ago

Works in ZK.

lolsteamroller commented 7 months ago

Was playing it recently and also was curious.

After testing, the issue comes from game version and after some game version, the s11n lib that creates those pipes (reclaimable objects in middle) are failing.

[Game::ClientReadNet][LOGMSG] sender="LSR" string="[Internal Lua error: Call failure] [string "libs/s11n/object_s11n.lua"]:353: attempt to call field 'echo' (a nil value)
stack traceback:
    [string "libs/s11n/object_s11n.lua"]:353: in function '__ReportObjectCreationFail'
    [string "libs/s11n/object_s11n.lua"]:397: in function 'Add'
    [string "LuaGaia/Gadgets/s11n_load_map_features.lua"]:45: in function 'GamePreload'
    [string "LuaGadgets/gadgets.lua"]:859: in function <[string "LuaGadgets/gadgets.lua"]:857>
    (tail call): ?"

game version 25265-a4a2a74 works game version 25270-b5940ec does not work

lolsteamroller commented 7 months ago

@Ruwetuin I think it's one of your cleanups that is causing s11n to fail, I'm not sure how to check precise version by version as Rapid for me only shows older versions when trying to download, but from my own existing versions, as noted in the comment above:

game version 25265-a4a2a74 works game version 25270-b5940ec does not work

image

Here is what changes were then issue popped up.

Ruwetuin commented 7 months ago

then those features must be in the .tdf format.... which are no longer supported/loaded