beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.71k stars 285 forks source link

Solving the dgun issues #3246

Open MeSaber opened 3 months ago

MeSaber commented 3 months ago

Description

Aiming just outside dgun range moves the commander then instantly fires if its facing its torso in that direction, if it aint facing with torso in same direction but 180 degrees even aiming inside the circle moves the commander, turns torso, then fires. The range is therefore measured from the dgun hand and not from the displayed dgun circle, i guess many just as me has issues with this where you want a standing still commander dgunning but instead it chooses to turn around and move, making both torso and legs desynced causing a dgun delay.

Armada commander: You dgun once just on the line in the facing direction, it fires at max range, then you dgun again but outside the circle, it should move then dgun but instead it gets stuck: https://i.imgur.com/CkFPg4H.jpeg

Cortex commander: You aim inside the circle (very far in) it moves the commander then dguns: https://i.imgur.com/RfnMjAA.jpeg <- this dgun click will move commander forward and a slight delay after dgun. The dgun circle isnt obeyed but its way offset towards the commander. I guess this was the 'fix' but it instead made dgun range way shorter (in sense of where you need to aim with mouse to release the projectile) https://i.imgur.com/zoivPKt.jpeg <- this is the range that is missing that you cant dgun in without moving commander.

Expected Behaviour

Aim dgun inside circle = it doesnt move and dguns, repeated dguns inside circle should still stand still even though enemy is 180 degrees of the current torso direction.

Actual Behaviour

Dgun hand is the measurement to whether the clicked dgun location is in range, then chooses to move legs accordingly to reach. Also some wonkyness with Cortex commander which is missing dgun range.

Reproduction steps

Dgun with small steps outwards towards the circle and you get mixed behaviours. Dgunning outside range after a dgun has been released causes Armada com to get stuck as Cortex was before.

Other

Why this is an issue in the first place is because the dgun originates from the gun towards your aimed location, so you have to aim exactly at the farthest point where the enemy is entering the circle or you will miss the dgun https://i.imgur.com/1MtKAbA.png

Beherith commented 3 months ago

For reference see https://docs.google.com/document/d/1q2I4VlExnCELH0ZJXqQ7hg-vJEmgP2PiBZxgkni6RWk/edit#heading=h.cghnu0xuhqff

some stuff might be deprecated.