search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.8k stars 302 forks source link

Swap Fight command Left and Right click drag behavior (or as an option) #3400

Open sprEEEzy opened 4 months ago

sprEEEzy commented 4 months ago

Description

Currently, the left click drag does a line formation fight with orientation displayed (pink arrow). Problem is that, first of all, this behavior is bugged. It doesn't do what it's supposed to, as displayed here: https://github.com/beyond-all-reason/Beyond-All-Reason/issues/3258

image image

Second, right click drag behavior is now in direct conflict with command cancellation on normal right click, which has been recently added. If you click Fight, then right click while mouse is still, it will deselect the command. Only if the mouse is in motion, can you issue Fight custom formation drag, and it also always gets deselected after issuing it, no matter if you're holding shift, so you cannot chain those commands without jumping thru many, many hoops.

Why?

If I had to choose, I'd much rather have the current RMB drag - Custom formation drag - than the line drag which doesn't even work, and is less customizable. As it is right now, that command is unusable, which is a detriment to good micro.

The custom formation fight command is more customizable and generally useful than the line with orientation. You can control unit orientation if you want by issuing an appropriate move command before the fight command, so I don't see much benefit of line with orientation anyway.

After that, the problem of right click drag conflict needs to be fixed (without removing the right click cancel command behavior!). Whether it's adding a modifier for the line with formation drag, or something else, it's up to the team.

What area of the game does this feature request pertain?

Gameplay, UI/UX, Settings, Controls or Hotkeys

Other (optional)

Please redirect this to the Spring issues forum if needed.

No response

WatchTheFort commented 4 months ago

This is a bug, where holding down Shift is not preserving the selected command, but switching back to the context command. In the case of Move, it is still happening, but because Move is the default context command on top of terrain, it doesn't get noticed.

WatchTheFort commented 4 months ago

After investigation, this does not happen with area commands or formation commands, suggesting that this is due to widget, as the line move command is implemented Lua-side.

sprEEEzy commented 4 months ago

I reported this as a bug already in https://github.com/beyond-all-reason/Beyond-All-Reason/issues/3258

This ticket is about having the option to switch LMB and RMB Fight drag click behavior, because I'd like the current RMB more than the LMB.

WatchTheFort commented 4 months ago

The behaviour must be consistent for all commands, e.g. all area commands must be issued the same way, all formation line commands must be issued the same way.