search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.7k stars 280 forks source link

tutorial [i18n] "tips.notifications.makeFactory" is not translated in en #3674

Closed aand18 closed 1 week ago

aand18 commented 2 weeks ago

Description

In the first mission of the tutorial, the "make factory" translation appears to be missing.

image

Expected Behaviour

"makeFactory" message should be displayed

Actual Behaviour

A notification is displayed [i18n] "tips.notifications.makeFactory" is not translated in en.

Reproduction steps

  1. start mission 1 of the tutorial
  2. place metal extractor(s) and windmill(s) - not sure the exact quantity to trigger the makeFactory message

Other

No response

WatchTheFort commented 2 weeks ago

@Ruwetuin this looks like a problem with how the sound notification widget is passing I18N keys, the entry in tips.json has always been buildFactory, not makeFactory.

Ruwetuin commented 1 week ago

fixed in https://github.com/beyond-all-reason/Beyond-All-Reason/commit/87b267d8d49a04d81ed6d0ae2c5a8585cd7cba96