search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.78k stars 298 forks source link

Depth of Field issues #855

Open MasterBel2 opened 2 years ago

MasterBel2 commented 2 years ago

A couple screenshots: screen00152 screen00135

Widget appears to blur the edges of the object in the foreground with the background; this should not occur. Also appears that certain effects (e.g. aircraft jets) completely ignore depth of field, creating a weird (and somewhat cool) visual glitch.

Beherith commented 2 years ago

Widget appears to blur the edges of the object in the foreground with the background; this should not occur -> bind and sample the map and model depth gbuffers (see lava shader for example).

Also appears that certain effects (e.g. aircraft jets) completely ignore depth of field, creating a weird (and somewhat cool) visual glitch. -> this is related to A, airjets seem to write to the depth buffer, disable this via depthmask(false), and b, draw ordering.

SethDGamre commented 3 weeks ago

If someone tackles this issue, while you're at it look at how depth of field interacts with grass. https://github.com/beyond-all-reason/Beyond-All-Reason/issues/1046