search

beyond-all-reason / bar-lobby

BAR Lobby Client
https://beyond-all-reason.github.io/bar-lobby/
MIT License
33 stars 30 forks source link

Friends List Transparency #167

Closed Descyphal closed 1 year ago

Descyphal commented 1 year ago

Friends list black box carries the same black area as the Direct Messages and Downloads windows and the remainder is transparent. And it does not scroll through my list.

image

thehobojoe commented 1 year ago

Does this always happen for you? Mine is correctly length-limited, and I need to scroll to see more:

https://user-images.githubusercontent.com/3493638/226755634-3ec2a78a-57b7-491a-aaee-439ff8b1f422.mp4

Descyphal commented 1 year ago

image 24 hour later, and yes, always been happening. Actually, it doesn't even scroll, brother. So I can't see my whole friends list.

Jazcash commented 1 year ago

Sorry for the confusion, this was already reported and I fixed here: https://github.com/beyond-all-reason/bar-lobby/issues/141 However, the fix isn't released yet, which is why it's fixed for your local dev setup @thehobojoe

I'm not sure if it's best to mark issues as resolved when they're fixed in master or when a release is made that includes the fix.

thehobojoe commented 1 year ago

Thanks for the clarification. I definitely think bugs should be closed when the issue is fixed, not when it's released. That could cause minor confusion with anyone dealing with a bug, but as long as we mark the issue resolved pending release it should be fine.

Jazcash commented 1 year ago

Resolved - pending release!