search

beyond-all-reason / bar-lobby

BAR Lobby Client
https://beyond-all-reason.github.io/bar-lobby/
MIT License
33 stars 30 forks source link

Button text gets hidden on overflow #194

Open Jazcash opened 1 year ago

Jazcash commented 1 year ago

image

Is an issue for smaller resolution/window size when elements get cramped and start to split lines. This can be fixed by removing the max-height: 35px; line in Control.vue, but that line was written as a hacky way to make all controls be the same vertical height, for pretty alignment. Instead it might be better for controls to fill their vertical space, but will need to test the whole app to make sure this doesn't break stuff, e.g:

image

The other alternative is forcing button text to always be on same line, then making sure that doesn't break sibling elements from getting pushed off horizontally.

dusekj4 commented 1 year ago

Maybe the best solutions is the most dumb :) . What about just renamed it to Host.

Jazcash commented 1 year ago

Maybe the best solutions is the most dumb :) . What about just renamed it to Host.

This issue isn't about this button specifically, but how to handle this problem in general

1-alex98 commented 1 year ago

Can only reproduce with developer tools. Otherwise min window size keeps this from happening