search

beyond-all-reason / bar-lobby

BAR Lobby Client
https://beyond-all-reason.github.io/bar-lobby/
MIT License
37 stars 35 forks source link

Rename game #229

Closed 1-alex98 closed 1 year ago

1-alex98 commented 1 year ago

Fixes #201

Jazcash commented 1 year ago

Could you merge latest master into this PR branch so hopefully CI passes?

1-alex98 commented 1 year ago

Please rerun CI

Jazcash commented 1 year ago

Am I right in thinking that $rename only works for the lobby boss? Someone told me the other day (sorry if it was you) that it's possible to find out the lobby boss with $rename:

image

I think we should add boss as a property to SpadsBattle and then use that to only show this rename button if the current user is the boss. I guess this would mean BAR Lobby would have to send $status on joining and then parse the DM output, and then also keep track of the boss with a handler for the * Boss mode enabled for Jazcash message.

Let me know if you want to give that a shot, otherwise I'll have a go at it.

1-alex98 commented 1 year ago

I think we should split up those issue. This is an improvement already. You can rename games. If you are not a boss you can your rename has no effect and you get a message that you need to be host.

1-alex98 commented 1 year ago

I did not implement the parsing of $status because I assume that this be obsolete soon since the new protocol will offer new ways of doingt this

1-alex98 commented 1 year ago

@Jazcash should I implement the $status thing? If yes I can do so. But if there soon will be another way to do that I would rather wait and do it later