Refactor CFile class and fix potential write corruption.

beyond-all-reason / pr-downloader

console downloader for spring maps/games written in c++

GNU General Public License v2.0

0 stars 8 forks source link

Refactor CFile class and fix potential write corruption. #12

Closed p2004a closed 2 years ago

p2004a commented 2 years ago

Dramatically simplifies the interface and removes all obsolete and dead code from the class.
Fixes a bug that made it possible to have a partial write to file corrupting it's content.

lhog commented 2 years ago

The amount of changes here is hard to grasp. I think we want to trust @p2004a judgement on this one. What do you think @Beherith ?

Beherith commented 2 years ago

Fully trust marek on this one

p2004a commented 2 years ago

If you want to review, for changes in Files.{cpp,h} I recommend just opening the new version of the file, not a diff, because it's mostly file deletions, end file is quite short but diff looks awful.

Changes in other places are not significant, but are there because contract of file operations changed (always create new temp file)