search

beyond-all-reason / pr-downloader

console downloader for spring maps/games written in c++
GNU General Public License v2.0
0 stars 8 forks source link

Fix accepting of unicode arguments by pr-downloade binary #23

Closed p2004a closed 2 years ago

p2004a commented 2 years ago

On Windows the regular argv is encoded in a very basic non-unicode codepage. This change properly reads them as unicode strings instead and encodes them as utf-8 into argv.

Fixes #16

(Making the PR as WIP for now as I want to test a bit more)

p2004a commented 2 years ago

@rafidka Ok, I've cleaned up the code a bit, and tested more e2e and it works.

The issue is that it will not help you and your friend much in the end, as engine seems to have even worse state of handling unicode: https://github.com/beyond-all-reason/spring/issues/355