search

beyond-all-reason / spads_config_bar

The Spring Perl Autohost Dedicated Server Configuration files for BAR
6 stars 26 forks source link

Shorter Teasers please #142

Closed jauggy closed 3 months ago

jauggy commented 3 months ago

Sample teaser: Boss name | Custom Battle 8 vs 8 should become simply 8 vs 8. It's taking up too much space on lobby browser and other info is getting cut off.

Discord discussion https://discord.com/channels/549281623154229250/549281623577722899/1269025159558332599

DeviousNull commented 3 months ago

145 should help with this a little, but I could be more aggressive with shortening it too.

What do you think of the following?

  1. If the lobby is empty/private then set the Teaser to empty
  2. Otherwise, if there is a Boss then set the teaser to Boss: NAME (or even 👑NAME, if the unicode-crown looks good in-game)
  3. Otherwise, set the teaser based on the current preset: Team 8v8 / Coop vs AI / Tourney / Custom 8v8

That way there would be at most one component added to the title by the Teaser

DeviousNull commented 3 months ago

After some brief testing, the 👑NAME idea seems non-trivial. It looks like Chobby doesn't appreciate Unicode characters in lobby names: 2024-08-04 17_51_45

So, I'm just going to update my existing PR to implement the logic mentioned above; that may reduce the number of characters enough.

jauggy commented 3 months ago

Based on the discord discussion: https://discord.com/channels/549281623154229250/549281623577722899/1269025159558332599

Many people just want 8v8 and nothing else. We don't need Team or Custom Battle. For the boss name it can take up a lot of space, but maybe just put name or just put Boss.

@FIr3baL any reason why we can't show symbols in the lobby title? I know that σ symbol for sigma works in other areas for Chobby.

FIr3baL commented 3 months ago

Based on the discord discussion: https://discord.com/channels/549281623154229250/549281623577722899/1269025159558332599

Many people just want 8v8 and nothing else. We don't need Team or Custom Battle. For the boss name it can take up a lot of space, but maybe that is something Chobby can handle for people with small screens i.e. me.

@FIr3baL any reason why we can't show symbols in the lobby title? I know that σ symbol for sigma works in other areas for Chobby.

Since chobby is written in LUA, it should be complete compatible with UTF-8. I guess it's a transport problem. You could try changing c.battle.update_lobby_title and s.battle.update_lobby_title to use base64 encoded strings to bypass any problems, that can occur with UTF-8. Unfortunatly this would need to be changed in teiserver+barmanager+chobby.

jauggy commented 3 months ago

Yeah probably not worth it if we have to do that. But thanks.

MitjaGrabbe commented 3 months ago

Hello, as Jauggy mentioned me as a frequent lobby hoster would prefer 8v8 without a boss name or custom game or teamgame prefix. People are mostly interested in the min rating or min chev level which is currently for most players not visible.

I host lobbies often and I have to say that this is one of the changes I do really dislike. to be precise I just stopped hosting lobbies as it is way to hard to create lobby names that read pleasant for the eye, hence people join. of course glitter lobbies etc dont face that issue.

Even if it isnt a custom game and so a proper ranked and the boss name then is shown in the back, it is still spam. Talked to many players. We seems to agree that this change isnt perceived as good. I rather would welcome a popup if I hover over a lobby with my mouse, or completly new collums in the lobby list seperated as maps currently are shown.

jauggy commented 3 months ago

Near and Kyouma and also agreed that boss is not necessary in the title https://discord.com/channels/549281623154229250/549281623577722899/1269025823395024988

Choice is also not a fan of the current naming scheme: https://discord.com/channels/549281623154229250/549281623577722899/1269055882797518939

DeviousNull commented 3 months ago

Beherith already merged the last PR, but I can put up another one later today when I have some time to work on it. Think this would work?

If bots are present: | PRESET_NAME vs BOT_TYPE If no bots are present:

jauggy commented 3 months ago

@DeviousNull sounds good

DeviousNull commented 3 months ago

All of my pending PRs to shorten teasers have been merged now, and most lobbies have updated to use the new names (the few remaining should get the update over the next few days or so).

If we want to go a few characters shorter, we could consider shortening the Min chev: / Min rating: prompts as well:

... but I'm not sure that's really necessary at this point.

jauggy commented 3 months ago

OK I see some good improvements in production now. Closing.

For further improvements I've got a ticket in chobby for allowing the length of the lobby browser to be wider: https://github.com/beyond-all-reason/BYAR-Chobby/issues/743

Currently you can go to Settings> Split Panel > Always One to make it wider but it also affects when you are in lobby.