search

beyond-all-reason / spring-launcher

Launcher for SpringRTS games
MIT License
2 stars 7 forks source link

Add workaround for Windows Antivirus #28

Closed p2004a closed 1 year ago

p2004a commented 1 year ago

Players on Windows have sometimes failing rename due to "operation not permited". It's fault of not great antivirus implementation and disabling antivirus helps.

I don't have clean setup where we can reproduce this, but it's possible that cause is the same as in: https://github.com/rust-lang/rustup/issues/1870 antivirus is scanning files after closure which on windows blocks moves.

Idea here is to try to workaround it by retrying all renames with backoff until some deadline and see if it mitigates the issue...

p2004a commented 1 year ago

Hopefully fixed 0a3a4a0b4a35a9fa6d354ca14c5fedab75e22cae, I'm closing assuming done