search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
205 stars 98 forks source link

Geothermal smoke ignores fog #1153

Open sprunk opened 8 months ago

sprunk commented 8 months ago

image

lhog commented 8 months ago

Well in theory the same should apply to all particles, but I'm not sure how good it's going to look.

lhog commented 8 months ago

This is an example of fog reactive particles: screen_2023-12-24_13-15-43-312 screen_2023-12-24_13-16-55-840

Unsure if it's good or bad.

lhog commented 8 months ago

For the posterity https://github.com/beyond-all-reason/spring/pull/1155

sprunk commented 8 months ago

Well my point was mostly that 100% fog shouldn't show anything, like in my exaggerated example. But this also looks fine, most games heavily reduce fog anyway.

lhog commented 8 months ago

That's nearly impossible to do, since the geo smoke and most other effects are alpha composed. So ideally the fog effect should be applied as post processing, but I'm not sure it's worth it.