search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
206 stars 99 forks source link

'Phantom Target' bug #1269

Open TheSilverHornet opened 9 months ago

TheSilverHornet commented 9 months ago

There is an erratic issue without known trigger, that is most likely to manifest on sweepfire weapons but -can- occur on others, Demon for example, wherein a phantom target is 'seen' by the unit and it goes full ham on said figment. Usually this target is about 90 to 120 degrees behind it, for some reason.

A notable example video can be found on discord here: https://discord.com/channels/549281623154229250/724924957074915358/1181723963018182797

The replay of that game is here: https://www.beyondallreason.info/replays?gameId=998e6a657fd743555e1ed61343a30e59

TheSilverHornet commented 9 months ago

2023-12-05_23-01-44-837_All That Glitters v2_105.1.1-2142-g35a026a BAR105.sdfz.zip image

hopefully enough data here to wrangle something useful from?

TheSilverHornet commented 9 months ago

I've narrowed this down to some relation to the emit-sfx function, if that helps at all. something in how it makes a fake target, or replaces the original, seems to have unexpected sideeffects. I have another weapon / unit that does the same if you need (more or cleaner) debugging examples

TheSilverHornet commented 9 months ago

2023-12-16_08-22-28-468_Quicksilver Remake 1_105.1.1-2152-gb91f41c BAR105.sdfz.zip

this is a static tower doing the same thing, and it behaves itself the moment the emit-sfx line is commented

image

lhog commented 7 months ago

2023-12-16_08-22-28-468_Quicksilver Remake 1_105.1.1-2152-gb91f41c BAR105.sdfz.zip

this is a static tower doing the same thing, and it behaves itself the moment the emit-sfx line is commented

image

I don't think there is any issue or erratic behavior in that replay

2023-12-05_23-01-44-837_All That Glitters v2_105.1.1-2142-g35a026a BAR105.sdfz.zip image

hopefully enough data here to wrangle something useful from?

I totally don't see units you have on your screenshot in this demo. Did you modify some files in the game locally?

TheSilverHornet commented 7 months ago

I don't think there is any issue or erratic behavior in that replay

The bastion has been edited since then, specifically to avoid this bug, so at this point it may not reflect what actually happened. I'll clear my replays folder out and check.

I totally don't see units you have on your screenshot in this demo. Did you modify some files in the game locally?

No more than a normal dev build, I don't believe I'd changed anything about the units in question, and relatively sure others haven't altered those since either. Again will check replay for sanity's sake and get back to you.

I can (re)make a version of a Bastion that does the same on current engine, but the replay I sent on discord on the engine version you provided might be best for debugging, if that contains related code that's pending merge? That only contains Incinerators but they manifest the same bug still, eg shooting imaginary targets somewhere behind them.

lhog commented 7 months ago

erraticfire_2024-02-05_05-09-08-271_All_That_Glitters_v2_105.1.1-2300-g43959c9_BAR105.sdfz.zip Updated replay

sprunk commented 2 days ago

1279 merged, can be closed?