search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
191 stars 97 forks source link

Rmlui/init shutdown reworking #1427

Closed ChrisFloofyKitsune closed 4 months ago

ChrisFloofyKitsune commented 4 months ago

simplified init/shutdown code

deferred the removal of Rml Contexts, allowing for removal of the mutex I naively threw in (the mutex didn't solve things in the end anyway)

slight work on tidying up event handling code (no functionality change)

blaisemccourtney commented 4 months ago

Looks good to me.

blaisemccourtney commented 4 months ago

@p2004a Would it make sense to merge these changes as they are, since they are just to a different branch, the one in #1415 ? The changes will also be reviewed there, and some/all of the changes are part of code review changes.