search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
182 stars 95 forks source link

Fix game loading crash #1438

Closed marcushutchings closed 2 months ago

marcushutchings commented 3 months ago

Fixes https://github.com/beyond-all-reason/spring/issues/1425

lua overally generic macros renamed to avoid clashes with EnTT and possibly clashes in future. The registry and cast macros were causing a huge problem with building.

marcushutchings commented 2 months ago

The seemingly-unrelated lua macros change could have been a separate commit but i can live with that

The lua macros were preventing the fix from compling. It wasn't trivally resolvable, the original work to do so wasn't addressing this case, so it was time to sort out those damn macros.

sprunk commented 2 months ago

The lua macros were preventing the fix from compling.

Yes, but not the other way around. But it's fine, no big deal.