search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
178 stars 95 forks source link

Some weapon types misuse `size` vs `collisionSize` #1480

Open sprunk opened 2 months ago

sprunk commented 2 months ago

size is for visuals and collisionSize is for setting the physical radius.

This one should use drawRadius (i.e. size) and not radius (i.e. collisionSize). There shouldn't be an arbitrary x1.3 multiplier either. https://github.com/beyond-all-reason/spring/blob/ab88be7e235eba1417dbfa07e95277b480283c0b/rts/Sim/Projectiles/WeaponProjectiles/FireBallProjectile.cpp#L60

This one should not multiply by size, keep it to collisionSize. https://github.com/beyond-all-reason/spring/blob/ab88be7e235eba1417dbfa07e95277b480283c0b/rts/Sim/Projectiles/WeaponProjectiles/FlameProjectile.cpp#L36

This one should not increase the physical radius, just the drawRadius, and not multiply by collisionSize again. https://github.com/beyond-all-reason/spring/blob/ab88be7e235eba1417dbfa07e95277b480283c0b/rts/Sim/Projectiles/WeaponProjectiles/FlameProjectile.cpp#L66-L68