search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
210 stars 99 forks source link

Footprint decal stretch regression #1491

Closed GoogleFrog closed 4 months ago

GoogleFrog commented 5 months ago

/give striderbantha

The decal only looks different for units with trackStretch != 1. I suspect the sign of an exponent was flipped somewhere in the new decal system.

2457 image

2031 image

GoogleFrog commented 5 months ago

Well, more of an unintended(?) behaviour change than a regression. But I'm not going to account for it until I know it is intentional, because it impacts a lot of places that are hard to reach (ie modding and other games).

sprunk commented 5 months ago

I think it's a good change because now a 0.5 stretch factor (like bantha has) makes each segment 0.5 the size. Smaller factor -> smaller segments.

lhog commented 5 months ago

Yeah I may have made it reciprocal accidentally. Since you're first to notice tell me if you want it the old way or is the new way fine?

sprunk commented 5 months ago

I prefer the new way because it is more intuitive and a gameside fix is trivial https://github.com/ZeroK-RTS/Zero-K/commit/00c47d467f757587fd92602c97246074506b391d

GoogleFrog commented 5 months ago

I have no preference for ZK, but it would nice to have one fewer thing to fix when updating an old game to work on modern spring.

lhog commented 5 months ago

Well seems like you have posted the fix to ZK already with the parameter read as is, so I assume we will move forward with that new semantics.

sprunk commented 4 months ago

There are other games than ZK though, but I think I can just PR the trivial fix for them approximately this weekend

sprunk commented 4 months ago

https://github.com/FluidPlay/TAP/pull/11 https://github.com/techannihilation/TA/pull/1678 MF and SF seem to have nothing to fix

Others TBD

sprunk commented 4 months ago

Looks like that's all.