search

beyond-all-reason / spring

A powerful free cross-platform RTS game engine
https://beyond-all-reason.github.io/spring/
Other
178 stars 95 forks source link

Fix some broken tests. #1545

Closed UnicodeSnowdude closed 2 weeks ago

UnicodeSnowdude commented 3 weeks ago

Not sure if I'm missing something, but it looks like several tests don't build.

A couple look like they have outright compile errors. (Like the engine code was updated, but the tests were not).

Another couple look to be missing dependencies on smmalloc.

I built on Linux using

mkdir build
cd build
cmake   -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
    -DCMAKE_CXX_FLAGS_RELWITHDEBINFO="-O3 -g -DNDEBUG -fdiagnostics-color=always" \
    -DCMAKE_C_FLAGS_RELWITHDEBINFO="-O3 -g -DNDEBUG -fdiagnostics-color=always" \
    -DCMAKE_BUILD_TYPE=RELWITHDEBINFO \
    -DAI_TYPES=NATIVE \
    -DINSTALL_PORTABLE=ON \
    -DCMAKE_USE_RELATIVE_PATHS:BOOL=1 \
    -DBINDIR:PATH=./ \
    -DLIBDIR:PATH=./ \
    -DDATADIR:PATH=./ \
    -DCMAKE_INSTALL_PREFIX="$(pwd)/install" \
    -G Ninja \
    ..
cd ..
ninja -C build tests
ninja -C build test
badosu commented 2 weeks ago

Are all tests green now? Even though they were unmaintained would be nice to have them running on the build as a foundation for others to come hopefully.

UnicodeSnowdude commented 2 weeks ago

testFileSystem and testCreg are both still failing. I'm on Linux, so I speculate the FileSystem issue is platform-specific. It looks like with Creg, the devs just stopped using it or got lazy with implementing it. Not sure. To be honest, I don't really know what Creg is.

badosu commented 2 weeks ago

Thank you!