search

beyond-all-reason / teiserver

Middleware server for online gaming
https://www.beyondallreason.info/
MIT License
47 stars 47 forks source link

Allow friends to join private battles without a password #285

Closed jere0500 closed 1 month ago

jere0500 commented 2 months ago

I want to allow friends to join private lobbies without having to enter a password. This should be easy by bypassing the password requirement when the gatekeeper of a lobby is set to friends.

General Idea: https://github.com/beyond-all-reason/BYAR-Chobby/issues/654

StanczakDominik commented 2 months ago

I haven't looked at this part of the code at all, so clarify one thing for me. Is this gate-keeper setting opt-in? Will this change all private games to open to friends, or is there something you still need to do to enable this bypass?

I'm asking primarily in the context of tournament games, where pretty much all top level players most likely have each other friended :P

StanczakDominik commented 2 months ago

Clarified by Lexon that this is okay :)

jere0500 commented 2 months ago

Yes, it is opt-in. You have to execute $gatekeeper friends to opt-in. This should be disabled by default. :)

I have added a checkbox in chobby that enables it automatically. https://github.com/beyond-all-reason/BYAR-Chobby/issues/654

StanczakDominik commented 1 month ago

All right, thanks for doing this! Happy to unblock chobby on it, it should be deployed within the week :)