beyond-all-reason / teiserver

Middleware server for online gaming
https://www.beyondallreason.info/
MIT License
46 stars 46 forks source link

Make CI great again #308

Closed geekingfrog closed 1 day ago

geekingfrog commented 1 month ago

Alternative title: declare test bankruptcy.

This PR adds a tag to ignore all currently failing tests. The output of mix test --exclude needs_attention is still drowned in error logs, but at least all tests are passing. This is making the CI step useful, if a known good test starts to fail, people will notice.

And then we can start having a look at slowly removing these tags and fixing the tests. There is really a mix bags:

geekingfrog commented 1 month ago

Should probably wait for https://github.com/beyond-all-reason/teiserver/pull/304 to be merged since the different otp/elixir version seems to be causing some issues.

StanczakDominik commented 1 month ago

I'm still getting 29 failures locally, 3 more than here in CI, when calling MIX_ENV=test mix do ecto.drop + test --exclude needs_attention :|

geekingfrog commented 1 month ago

I'm still getting 29 failures locally, 3 more than here in CI, when calling MIX_ENV=test mix do ecto.drop + test --exclude needs_attention :|

Yeah, this needs more work, I'll get to it at some point this week

geekingfrog commented 1 month ago

riiiight, so this passes locally, but not in CI, that one isn't going to be fun

StanczakDominik commented 1 month ago

Maybe even have multiple separate tags for those? Probably overkill and silly, but something to consider.

geekingfrog commented 1 week ago

Alright, I managed to reproduce the errors. I "fixed" them by disabling even more tests. They were all related to (old) tachyon stuff so I don't feel too bad. These tests are likely going to get deleted soon, once we get something working with the ws based tachyon.