beyond-all-reason / teiserver

Middleware server for online gaming
https://www.beyondallreason.info/
MIT License
50 stars 47 forks source link

Remove boss block #381

Closed L-e-x-o-n closed 1 month ago

jauggy commented 1 month ago

I'm guessing Lexon must have been blocked by someone :P

I do suggest you consider either these PRs below as they still allow people who want full control over their lobbies:

Hijacked lobbies don't apply boss blocks: https://github.com/beyond-all-reason/teiserver/pull/364

Only custom preset lobbies allow boss blocks. https://github.com/beyond-all-reason/teiserver/pull/372

However, this affects Lexon more than me since I barely play so if it's really annoying him then it's his call.

L-e-x-o-n commented 1 month ago

I have never been affected by this feature. I think the boss block idea is good but multiple people raised some valid potential issues woth it. I just prepared the work and was planning to leave it to GDT or someone else to decide what to do with it.

However, Jauggy reminded me of those other PRs and I think they are a much better solution so I am closing this PR now.

L-e-x-o-n commented 1 month ago

Sorry @jauggy, not sure how I missed your earlier PRs on this topic.