search

beyond-all-reason / teiserver

Middleware server for online gaming
https://www.beyondallreason.info/
MIT License
55 stars 53 forks source link

[Feature]: Allow anyone with the password to join lobby even with gatekeeper on #470

Open AntlerForce opened 2 weeks ago

AntlerForce commented 2 weeks ago

Describe the Feature

Currently if gatekeeper is enabled for a room all joins from non-friends are blocked even if they have the correct password. There is no message about the block and from the would-be-joiners perspective it just appears that "nothing happens".

IMO having the gatekeeper allow friends passwordless access and still accept the distributed password from non-friends would be much more useful and less confusing.

Expected Behavior

Enabling gatekeeper allows friends joining without inputting the password, while not preventing those who are not friends but have the password from joining.

Screenshots

No response

Additional context

This is a chobby PR that I am not comfortable merging while gatekeeper operates in the current way, as it is confusing why a password is given which doesn't actually allow people to join: https://github.com/beyond-all-reason/BYAR-Chobby/pull/665/

jauggy commented 2 weeks ago

It seems like the original intention for gatekeeper friends is for non-passworded lobbies.