search

beyond-code-github / LinqToQuerystring

A lightweight subset of oData querystring conventions that works with any IQueryable
MIT License
136 stars 63 forks source link

added support for UTC times #32

Closed mbonig closed 10 years ago

mbonig commented 10 years ago

I found that when supplying a datetime it was always taking it as local to the client, but we deal with everything via UTC times. Just addeding the "Z" to the end of the datetime was causing it to no longer match against the type so I added the optional 'Z' at the end of the grammar check. Did some local testing and things seem pretty good.

mbonig commented 10 years ago

Have you had a chance to review this PR yet?

beyond-code-github commented 10 years ago

I'm so sorry I had missed this one coming in! I'll try and get back to you later this week.

On Mon, Apr 28, 2014 at 3:38 PM, mbonig notifications@github.com wrote:

Have you had a chance to review this PR yet?

— Reply to this email directly or view it on GitHubhttps://github.com/Roysvork/LinqToQuerystring/pull/32#issuecomment-41565849 .

mbonig commented 10 years ago

Thanks for getting this merged in, it's a huge help!

beyond-code-github commented 10 years ago

My pleasure! Just sorry it took so long :)

mbonig commented 10 years ago

Hi Pete,

Ran into an issue today and I wanted to run it by you...

let's say this is my query string:

$top=10&$skip=0&$orderBy=CreateDate desc

Everything works great

If I change it to this:

$skip=0&$orderBy=CreateDate desc&$top=10

Then the top doesn't appear to be applied to my results. In this case I'm using this against a queryable exposed by the MongoDB client API. With the second query, shifting the $top to the end of the query, the result set doesn't get limited.

I'm trying to dig more into this now and see if I can figure out if this is a MongoDB thing or not. Any thoughts otherwise?

BTW, hope your talk goes/went well. =-]

Thanks, M

On Mon, May 5, 2014 at 10:20 AM, Pete Smith notifications@github.comwrote:

My pleasure! Just sorry it took so long :)

— Reply to this email directly or view it on GitHubhttps://github.com/Roysvork/LinqToQuerystring/pull/32#issuecomment-42206047 .