Fix method signature to comply with the interface implemented by the class

beyondcode / dusk-dashboard

A beautiful dashboard for your Laravel Dusk tests

https://pociot.dev/8-introducing-laravel-dusk-dashboard

MIT License

559 stars 63 forks source link

Fix method signature to comply with the interface implemented by the class #17

Closed nikazooz closed 5 years ago

nikazooz commented 5 years ago

Hi!

First of all, thanks for this great tool! 🙂It's really going to improve automated browser testing with Laravel Dusk.

When running php artisan dusk:dashboard I get error that declaration of onMessage method on BeyondCode\DuskDashboard\Ratchet\Socket class is not compatible with the signature of Ratchet\WebSocket\MessageCallableInterface interface that is implemented through Ratchet\WebSocketMessageComponentInterface.

See the screenshot:

This PR fixes that.

Thanks again!

mpociot commented 5 years ago

Thanks. No idea why it didn't complain on my end.

nikazooz commented 5 years ago

Don't know, but I've noticed this happens when using PHP 7.1 but not with version 7.2