fix: bind configuration before binding a client in createClient

beyondcode / expose

A beautiful, fully open-source, tunneling service - written in pure PHP

https://expose.dev

MIT License

4.24k stars 262 forks source link

fix: bind configuration before binding a client in createClient #381

Closed stumpc closed 1 year ago

stumpc commented 1 year ago

Issue:

in app/Client/Factory.php, bindClient() is called before bindConfiguration() in createClient(). This causes the created client to not have any changes to the configuration. Namely, this causes ShareCommand to effectively ignore an input option for --auth, instead defaulting to whatever is in the expose.php config file.
This change should fix the issue here: https://github.com/beyondcode/expose/issues/175 . The asked-for --token option should already be satisfied by the --auth option, but due to this bug it was not behaving correctly.

what-the-diff[bot] commented 1 year ago

PR Summary

Changed method order in binding Swapped the order of bindClient() and bindConfiguration() methods for better organization.
Added comment for createClient method Included a description to explain the purpose and functionality of the createClient method.

stumpc commented 1 year ago

Closing since I think I might have gotten a bit ahead of myself. Locally I'm not experiencing the bug on the master branch the same way I experience it when I use expose in a container via Laravel Sail (sail share command) or otherwise, so I wonder if this was fixed somehow else and has not flowed through the version of that project I am using right now.