Not adding headers to queueable mailables

beyondcode / helo-laravel

HELO Laravel helper package to add

MIT License

87 stars 24 forks source link

Not adding headers to queueable mailables #12

Closed zupolgec closed 3 years ago

zupolgec commented 4 years ago

Fixes #5

There is a bug in Laravel (https://github.com/laravel/framework/issues/17283) that prevents Mailable with callbacks to be serialized for queueing.

So when a Mailable implements ShouldQueue we don't add headers.

Also changed the check from MailableContract to Mailable since the applyDebugHeaders function expects a Mailable (that has a view property).

jasonvarga commented 4 years ago

Doesn't this just remove the debug feature for queued mail?

zupolgec commented 4 years ago

Yes, because this feature is not available on queued Mailables. This package could provide a modified HeloMailable to extend, but what is the point of debugging locally the content of enqueued Mailables?

sebwas commented 3 years ago

Why has this not been merged yet? @mpociot

mpociot commented 3 years ago

Thank you!