search

beyondcode / helo-laravel

HELO Laravel helper package to add
MIT License
88 stars 25 forks source link

Move adding view namespace to boot method #21

Closed patrickbrouwers closed 4 years ago

patrickbrouwers commented 4 years ago

Calling View:: in the register method resolves the View Factory very early in the registering process. I've ran into an issue in which the View is resolved earlier some the other service providers are registered

Relevant packages: blade-icons, heroicons and zondicons.

Because of the View::addNamespace call in Helo service provider, zondicons register method is called after the view is resolved.

By moving the addNamespace call to the boot method, this issue is resolved and should work exactly the same I believe.

mpociot commented 4 years ago

Thank you!