search

beyondcode / herd-community

71 stars 1 forks source link

[Bug]: different `cli/Valet/Drivers/ValetDriver.php` than core valet #812

Open marcorieser opened 2 weeks ago

marcorieser commented 2 weeks ago

Platform

macOS

Operating system version

macOS Sonoma Version 14.5 (23F79)

System architecture

Intel (x86)

Herd Version

1.7.1 (Build: 28)

PHP Version

No response

Bug description

I'm using Statamic and run herd which and it outputs: This site is served by [Valet\Drivers\LaravelValetDriver]. but it should be served from StatamicValetDriver. I searched for a solution and found that PR where the Statamic driver gets injected before the Laravel driver.

When I diff the core valet driver file with my local bundled one in /Applications/Herd.app/Contents/Resources/valet/cli/Valet/Drivers/ValetDriver.php they are not the same.

I've no idea why Herd seems to bundle an older version of valet or why they differ.

Steps to reproduce

No response

Relevant log output

No response

mpociot commented 2 weeks ago

Herd is running a customized version of Valet, which is why there's a difference. I'll update the driver in the next release. In the meantime you can use a custom Valet driver for your projects.

marcorieser commented 2 weeks ago

Thanks